CommentFileSizeAuthor
#5 footermap-delete_variable_while_uninstalling_module-2675742-4.patch505 bytessonamsingh
#3 footermap-delete_variable_while_uninstalling_module-2675742-1.patch532 bytessonamsingh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sonamsingh created an issue. See original summary.

sonamsingh’s picture

sonamsingh CreditAttribution: sonamsingh commented
Assigned: Unassigned » sonamsingh
sonamsingh’s picture

sonamsingh CreditAttribution: sonamsingh commented
Assigned: sonamsingh » Unassigned
Status: Active » Needs review
FileSize
footermap-delete_variable_while_uninstalling_module-2675742-1.patch532 bytes

The patch deletes all the variables created by the module while uninstalling it.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
CreditAttribution: mradcliffe commented 
+++ b/footermap.install
@@ -0,0 +1,14 @@
+  // Clearing variables cache.
+  cache_clear_all('variables', 'cache');

Is it necessary to clear cache. I thought cache was going to be cleared on module uninstall or module enable anyway?

sonamsingh’s picture

sonamsingh CreditAttribution: sonamsingh at Innoraft commented
FileSize
footermap-delete_variable_while_uninstalling_module-2675742-4.patch505 bytes

Here's the new patch for the same. Thank you mradcliffe for pointing out that.

  • mradcliffe committed 321ea38 on 7.x-1.x authored by sonamsingh 
    Issue #2675742 by sonamsingh28: Delete variables while uninstalling the...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
CreditAttribution: mradcliffe commented
Status: Needs review » Fixed

Everything looks good and works. Thank you for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.