Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Steps to reproduce.
Enable entity_translation entity_translation_i18n_menu
Enable a second language.
Set node type and menu as translatables.
Translate a node to both languages setting including a translation of the menu link description that includes a character like '&'.
Save the translations and edit the translation that is not the source.
You will notice that the ampersand is now "&".
Everytime you save the node the & will be expanded to & creating strings like "&" ad infinitum.
Comments
Comment #2
rodrigoaguileraSince we are displaying a string for a form it doesn't need to be sanitized but that happens in the i18n_menu.
My patch copies the the two functions from i18n_menu involved
_i18n_menu_link_localize
_i18n_menu_link_description
and disables sanitization for the description.
Comment #3
rvilarIt works for me!
Comment #4
stefanos.petrakis@gmail.comThank you both for (a) identifying and working on this issue and (b) providing feedback on the proposed solution.
Unfortunately, the solution provided by the patch in #2 has some weak points, most importantly the copy-n-paste approach.
Additionally, after looking deeper into the whole issue, I believe the problem lies on the
i18nside, andEntity Traslationshould not try to amend that problem, but we should rather try to solve this insidei18n.There is a related issue and a patch available over at #2973611-2: _i18n_menu_link_description(): String sanitization should be disabled for the menu item's description to be displayed correctly that should solve this problem. Actually there are two different problems with the same origin, one has to do with the rendering of the description of translated menu links, the second one is the one reported here.
Applying that patch against
i18nsolves both problems.I updated the
entity_translation_i18n_menutests in order to cover the reported problem as well as the rendering case and I am submitting the changes here.N.B.: The updates tests should fail if the patch from #2973611-2: _i18n_menu_link_description(): String sanitization should be disabled for the menu item's description to be displayed correctly is not applied.
Next steps:
Till the related
i18nissue and related patch are committed, or an alternative solution appears, we should keep this issue open.Comment #5
joseph.olstadtrigger runners
Comment #7
joseph.olstadso if your related i18n module patch is committed, will this then pass?
#2973611: _i18n_menu_link_description(): String sanitization should be disabled for the menu item's description to be displayed correctly
Comment #8
joseph.olstadok, yes, I will commit the related i18n patch and re trigger these tests.
Comment #9
joseph.olstadretriggered all tests after i18n commit
Comment #11
joseph.olstadI just checked the job console
the job is pulling the latest tagged release of i18n, not the latest dev of i18n
so, will have to tag a release of i18n to get this test to pass.
Stefanos, have you ran these tests locally?
that would work, if the dev version of i18n was pulled locally, and run this patch against et
Comment #12
stefanos.petrakis@gmail.comHi @joseph, I did run them locally yes! With the next tagged release of i18n, the tests should pass.
And according to the bot, the patch with the new tests need some coding standard corrections.
"Needs work" seems good for now.
Comment #13
joseph.olstadI've tagged and released i18n 7.x-1.25
I'd say this patch above is ready for commit.
Thanks
Comment #14
stefanos.petrakis@gmail.comThanks @joseph, let's check with the bot first.
Comment #15
joseph.olstadlooks good so far, I just queued a few extra tests
Comment #17
stefanos.petrakis@gmail.comNew tests are green, closing this "works as designed". Many thanks for the help on this to everyone involved.
Comment #18
joseph.olstadnice to get that extra test coverage there, thanks Stefanos! Great work!
BTW, shameless plug here, have you tried the new entity_translation_unified_form module yet? it's really really good! to get pathauto working correctly make sure to install both pathauto_i18n and pathauto_i18n_node