Hi,

I'm using this module to geocode addresses and would like to catch exceptions when Google API fails (e.g. returns some error or status that is not OK). I investigated a bit the source code and found that module also throws exception when API returns zero results (i.e. returns status ZERO_RESULTS). Wouldn't it be better to return empty result as it is expected behaviour for incorrect input data?

Thanks in advance

Comments

aprogs created an issue. See original summary.

AdamPS’s picture

Status: Active » Closed (duplicate)
Related issues: +#2689211: Confusion with errors and logging

I agree. I have just raised a more detailed and comprehensive issue so I hope you don't mind if I close yours as a duplicate.

AdamPS’s picture

I have a patch in the related issue. If you get a chance to test and review that would be appreciated.