Hello,

As Drupal8 enables the use of different logging system by implementing the Drupal\Core\Logger\LoggerChannelFactoryInterface (e.g Monolog ), Metatag shouldn't depends on the abstraction (e.g Drupal\Core\Logger\LoggerChannelFactory).

CommentFileSizeAuthor
#3 use-2672892-3.patch1.25 KBborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tigitz created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Category: Bug report » Feature request
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ commented
Status: Active » Needs review
FileSize
use-2672892-3.patch1.25 KB
mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
CreditAttribution: mr.baileys at Calibrate commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Makes total sense, reviewed the patch, applied the patch and tested by triggering a logged error.

Not sure if we want to bikeshed naming, but core seems to favour $logger_factory instead of $channelFactory as name (example, see \Drupal\Core\Mail\MailManager)

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

I think this should be changed to just use \Psr\Log\LoggerInterface instead of the logger channel factory, unless there's a specific need to have the factory instead of the logger itself.