If I want to use a nice, accessible more link text like:

View all<span class="element-invisible"> news articles</span>

I can't because views_plugin_display->render_more_link() uses check_plain(). This is a bit excessive because we allow simple HTML elsewhere in Views configuration. We could use filter_xss_admin() instead.

CommentFileSizeAuthor
#6 2671576-views-render_more_link-filter_xss_admin-6.patch581 bytesxlin
#5 2671576-views-render_more_link-filter_xss_admin-5.patch715 bytesgrndlvl
#4 2671576-views-render_more_link-filter_xss_admin-3.patch613 bytesdalin
#2 2671576-views-render_more_link-filter_xss_admin-1.patch695 bytesdalin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dalin created an issue. See original summary.

dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin at Advomatic for Annenberg Foundation commented
Assigned: dalin » Unassigned
Status: Active » Needs review
FileSize
2671576-views-render_more_link-filter_xss_admin-1.patch695 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2671576-views-render_more_link-filter_xss_admin-1.patch, failed testing.

dalin’s picture

dalin
he/him
Primary language English
Location 🇲🇽, 🇨🇦, 🌍
CreditAttribution: dalin at Advomatic for Annenberg Foundation commented
Status: Needs work » Needs review
FileSize
2671576-views-render_more_link-filter_xss_admin-3.patch613 bytes

Not quite sure why the first one failed. There was only a but if fuzz due to the original patch being against 3.13.

grndlvl’s picture

grndlvl CreditAttribution: grndlvl at GollyGood Software for Zivtech commented
FileSize
2671576-views-render_more_link-filter_xss_admin-5.patch715 bytes

Re-rolling patch.

xlin’s picture

xlin CreditAttribution: xlin as a volunteer commented
FileSize
2671576-views-render_more_link-filter_xss_admin-6.patch581 bytes

Re-rolling patch.