We are running in a situation where we need to enable hide_submit per role. Especially the ability to disable it for anonymous users.

CommentFileSizeAuthor
#4 disable_hide_submit_per-2671172-4.patch1.38 KBSpaghettiBolognese
#2 disable_hide_submit_per-2671172-2.patch1.38 KBSpaghettiBolognese
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SpaghettiBolognese created an issue. See original summary.

SpaghettiBolognese’s picture

SpaghettiBolognese CreditAttribution: SpaghettiBolognese at Emble commented
Assigned: SpaghettiBolognese » Unassigned
Status: Active » Needs review
FileSize
disable_hide_submit_per-2671172-2.patch1.38 KB

This patch implements hook_permissions().

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Status: Needs review » Needs work

This seems good to me, but...if someone upgrades their hide_submit module then it will suddenly stop working until they grant the permission to the proper roles on their site.

I wonder if we can make it a negative permission so that installs and upgrades will get the hiding behavior by default. Maybe "bypass hide submit" is the permission name?

Another alternative would be to auto-grant the permission to anonymous and authenticated roles on install and in an update hook. However, it feels a bit weird to grant permissions by default in Drupal.

SpaghettiBolognese’s picture

SpaghettiBolognese CreditAttribution: SpaghettiBolognese at Emble commented
FileSize
disable_hide_submit_per-2671172-4.patch1.38 KB
SpaghettiBolognese’s picture

SpaghettiBolognese CreditAttribution: SpaghettiBolognese at Emble commented
Status: Needs work » Needs review

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Status: Needs review » Fixed

Wonderful, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.