Problem/Motivation

Its possible to nest form element without changing the actual form structure in D8. Sadly this is only supported in Form API and not in Render API, nevertheless there isa huge benefit because the form structure won't change with field group enabled and makes other form alter way more easier.

Proposed resolution

Use #group for forms, keep the nesting logic for entity view modes.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 grouping-settings.png315.79 KBnils.destoop
#12 grouping-result.png133.21 KBnils.destoop
#12 grouping-2669904-11.patch12.11 KBnils.destoop
#8 2669904-8.patch3.51 KBwebflo
#7 2669904-7.patch3.51 KBwebflo
#3 2669904-2.patch3.73 KBwebflo
#2 2669904-1.patch4.29 KBwebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
FileSize
2669904-1.patch4.29 KB

Just a WIP patch.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
FileSize
2669904-2.patch3.73 KB
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Active » Needs review

The last submitted patch, 2: 2669904-1.patch, failed testing.

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Needs work

Patch needs a reroll.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Needs work » Needs review
FileSize
2669904-7.patch3.51 KB
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
FileSize
2669904-8.patch3.51 KB
nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop as a volunteer and at Wunder commented
Status: Needs review » Needs work

Tested this patch in combination with field layout module. As this type of grouping will be the fix for #2878359: Field groups are not compatible with field layout. But when applying the patch, and adding a tabs group + tab group, you receive a "Maximum function nesting level of '256' reached, aborting!". The nesting of details is working.

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop as a volunteer and at Wunder commented
Status: Needs work » Closed (works as designed)

Closing this one in favor of #2878359: Field groups are not compatible with field layout

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop as a volunteer and at Wunder commented
Status: Closed (works as designed) » Needs work

Re-opening this. I needed to fix field layout support using the old way. Using #groups was working for almost all group types, except vertical tabs. Vertical tabs has his own way of creating groups. The tabs always showed up in the root. Even when they were nested inside other groups.
I'll update with latest version of a patch.

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop as a volunteer and at Wunder commented
FileSize
grouping-2669904-11.patch12.11 KB
grouping-result.png133.21 KB
grouping-settings.png315.79 KB

Updated patch + screenshots that show remaining issue. You'll see that the vertical tabs is shown as last group, but it should be inside the fieldset

Settings

settings

Result

result

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop as a volunteer and at Wunder commented
Status: Needs work » Closed (duplicate)

On mean while, I tackled this issue. Will be updated in #2878359: Field groups are not compatible with field layout