Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
It would be great if the default "Send message" button text could be overridden.
Proposed resolution
Add a "Submit button text" field on each contact form's "edit" page, make the magic happen.
Remaining tasks
Review and commit (please).
User interface changes
The addition of a new "Submit button text" field.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#22 | 2669794-button-text.22.patch | 5.43 KB | larowlan |
| |||
#22 | interdiff.txt | 6.69 KB | larowlan |
#16 | submit_text-2669794-16.patch | 4.3 KB | jamadar |
#12 | submit_text-2669794-12.patch | 3.32 KB | ultimike |
Comments
Comment #3
andyposthere should be default value somehow
Comment #4
larowlanYou need a schema change for this
Also, needs tests.
Comment #5
jamadar CreditAttribution: jamadar as a volunteer and commentedI assingned this myself as a part of #TCSHackthon.
Comment #6
jamadar CreditAttribution: jamadar as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commentedComment #7
jamadar CreditAttribution: jamadar as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commentedIssue has been fixed please review
Comment #8
nidhi.badani CreditAttribution: nidhi.badani as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commentedWill be reviewing it in next 30mins.
Comment #9
nidhi.badani CreditAttribution: nidhi.badani as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commentedHey this works, I installed the required module and applied the patch. The submit button text is as specified while creating the form.
Looks good to me.
Comment #10
ultimike@jamadar - thanks for taking this on!
I just updated the patch with a couple of small formatting tweaks and the addition a reasonable default value (see comment 3).
It still needs a test. I'm looking into that now.
thanks,
-mike
Comment #12
ultimikeOk - here's a patch with a test.
-mike
Comment #14
jamadar CreditAttribution: jamadar as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commented#drupalconasia2016
Comment #15
jamadar CreditAttribution: jamadar as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commentedComment #16
jamadar CreditAttribution: jamadar as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commented@ultimike Thanks for providing patch.
I have tested this patch at my end and found that there is issue with the test cases in ContactStorageTest.php at line number 77.
Please find attached new updated patch to resolve this issue.
Comment #17
jamadar CreditAttribution: jamadar as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commentedComment #19
jamadar CreditAttribution: jamadar as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commentedComment #20
larowlanwhitespace issue here
unneeded change
Unneeded changes
Comment #21
larowlanWorking on this
Comment #22
larowlanComment #23
larowlanComment #25
larowlanComment #26
larowlan