This issue is a follow up for this 8cc29e49c8fa6887467067de85076f8e5153fe3d commit. It looks like this was an attempt to fix some code style issues, but also it accidentally reverted changes from previous commit.

Will fix this.

CommentFileSizeAuthor
#5 restore_usage_of-2669430-5.patch1.13 KBtobiasb
#2 style-interdiff.txt6.22 KBRoSk0
#2 2669430-2-fix-with-style.patch7.16 KBRoSk0
#2 2669430-2-fix-only.patch1.08 KBRoSk0
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RoSk0 created an issue. See original summary.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 at Catalyst IT commented
Assigned: RoSk0 » Unassigned
Status: Active » Needs review
FileSize
2669430-2-fix-only.patch1.08 KB
2669430-2-fix-with-style.patch7.16 KB
style-interdiff.txt6.22 KB

Patch as promised.

2669430-2-fix-only.patch - is the patch with only restoring of drupal_http_request().
2669430-2-fix-with-style.patch - same with the fixes for the code style violations I found.
style-interdiff.txt - Interdiff between those to.

jweowu’s picture

jweowu CreditAttribution: jweowu commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#1587598: Use drupal_http_request() instead of file_get_contents()

RoSk0's analysis and fix looks correct to me.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb as a volunteer commented
Version: 7.x-2.9 » 7.x-3.3
Status: Reviewed & tested by the community » Needs work

Patch does not apply anymore.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb as a volunteer commented
Status: Needs work » Needs review
FileSize
restore_usage_of-2669430-5.patch1.13 KB
jweowu’s picture

jweowu CreditAttribution: jweowu commented

Comparing the new patch against the old one, that certainly looks like a sane re-roll.

  • tobiasb authored f4cb5ee on 7.x-3.x 
    Issue #2669430 by RoSk0, tobiasb: Restore usage of drupal_http_request()
daveferrara1’s picture

daveferrara1 CreditAttribution: daveferrara1 commented
Status: Needs review » Fixed

Fixed in 7.x-3.5

daveferrara1’s picture

daveferrara1 CreditAttribution: daveferrara1 commented
Status: Fixed » Closed (fixed)