Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
There is no indication in the logs when the module is activated or inactivated.
Proposed resolution
Add watchdog entry when the module is activated and inactivated.
Remaining tasks
Fix the issueCreate a patchReview the patchCommit the patch
User interface changes
None.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#3 | email_verify-log_activation_inactivation-2669256-3-D7.patch | 854 bytes | oadaeh |
Comments
Comment #2
oadaeh CreditAttribution: oadaeh at Hook 42 commentedComment #3
oadaeh CreditAttribution: oadaeh at Hook 42 commentedThe attached patch addresses this issue.
Comment #4
Kristen PolI'm confused as to why this is here. How can the module be disabled if we are submitting its settings form?
Comment #5
oadaeh CreditAttribution: oadaeh at Hook 42 commentedIt's not that the module is disabled, it's that it's inactivated. Both the PHPMailer and SMTP Authentication Support modules use a similar concept.
It's an extra step in using the module. Previously, when the module was enabled on the modules page, it would go through a process of checking to see if it could work on the site it was installed on. Sometimes while doing that, it would cause the page to timeout and information to be lost and modules to be left in a weird state. I added this activation step on and moved the capability checks to the configuration page to minimize the likelihood of that happening.
I see I need to change the name of the email_verify_enable_module() function, as that name isn't correct. It should be something more like email_verify_test_capability().
Comment #6
oadaeh CreditAttribution: oadaeh at Hook 42 commentedComment #7
Patrick Storey CreditAttribution: Patrick Storey at Hook 42 commentedTesting the patch in comment #3, prior to adding the patch there were no watchdog entries for the module being activated or inactivated at /admin/config/system/email_verify.
After adding the patch, there were watchdog entries for the module being activated and inactivated.
This has passed testing.
Comment #9
oadaeh CreditAttribution: oadaeh at Hook 42 commentedThis has been committed to the 2.x dev branch. Thanks for the reviews and testing.
Comment #10
Kristen PolThanks!
Comment #11
oadaeh CreditAttribution: oadaeh at Hook 42 commented