Problem/Motivation

The name of the email_verify.inc.php file is not consistent with practices for modules and include files on d.o, nor within this module itself.

Proposed resolution

Rename email_verify.inc.php to email_verify.inc, so that it is in-line with normal Drupal practices.

Remaining tasks

  1. Fix the issue
  2. Create a patch
  3. Review the patch
  4. Commit the patch

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 email_verify-rename_inc_file-2669082-5-D7.patch14.13 KBoadaeh
#3 email_verify-rename_inc_file-2669082-3-D7.patch0 bytesoadaeh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oadaeh created an issue. See original summary.

oadaeh’s picture

oadaeh CreditAttribution: oadaeh at Hook 42 commented
Issue summary: View changes
oadaeh’s picture

oadaeh CreditAttribution: oadaeh at Hook 42 commented
Assigned: oadaeh » Unassigned
Status: Active » Needs review
FileSize
email_verify-rename_inc_file-2669082-3-D7.patch0 bytes

The attached patch addresses this issue.

oadaeh’s picture

oadaeh CreditAttribution: oadaeh at Hook 42 commented
Issue summary: View changes
oadaeh’s picture

oadaeh CreditAttribution: oadaeh at Hook 42 commented
FileSize
email_verify-rename_inc_file-2669082-5-D7.patch14.13 KB

Now, with even more content to the patch.

aimeerae’s picture

aimeerae
she/her
Primary language English
Location San Francisco, CA
CreditAttribution: aimeerae at Hook 42 commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • oadaeh committed 14a555a on 7.x-2.x 
    Issue #2669082 by oadaeh, Aimee Degnan: Rename email_verify.inc.php to...
oadaeh’s picture

oadaeh CreditAttribution: oadaeh at Hook 42 commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

This has been committed to the 2.x dev branch. Thanks for the review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.