sass (3.4.21), scss_lint (0.44.0) released

CommentFileSizeAuthor
#5 2667922-5.patch419 bytesskyredwang
#2 2667922-2.patch428 bytesskyredwang
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

skyredwang created an issue. See original summary.

skyredwang’s picture

Status: Active » Needs review
FileSize
428 bytes

Here is the patch

skyredwang’s picture

Hmm, all we need from Ruby side is scss_lint. The minimal version is already specified in Gemfile, do we really need Gemfile.lock?

SidneyGijzen’s picture

I ran into the same when I updated Zen to the latest dev release (from 28-12-2015) last week. The Gemfile.lock lists the Gems installed in the committers' environment. So, I would like to suggest that the Gemfile.lock shouldn't be included at all, since it is tied to one's specific environment.

skyredwang’s picture

FileSize
419 bytes

The attached patch is to delete this file from starterkit. But, we might need to do something to prevent this file being generated from install.

JohnAlbin’s picture

Title: Update Gemfile.lock to include the latest updates » Remove Gemfile.lock and move "version lock" to Gemfile

The idea was that we need to lock down the version of scss_lint because it is pre-1.0.0 and keeps introducing new build-breaking lint checks.

But since we are only tracking a single Gem now, we can "lock the version" in the Gemfile instead, since we really do not want 0.49 or later.

  • JohnAlbin committed 297eae9 on 7.x-6.x
    Issue #2667922 by skyredwang, JohnAlbin: Remove Gemfile.lock and move "...
  • JohnAlbin committed 86c49b5 on 7.x-6.x authored by skyredwang
    Issue #2667922 by skyredwang: Remove Gemfile.lock and move "version lock...
JohnAlbin’s picture

Status: Needs review » Fixed

  • JohnAlbin committed 297eae9 on 8.x-7.x
    Issue #2667922 by skyredwang, JohnAlbin: Remove Gemfile.lock and move "...
  • JohnAlbin committed 86c49b5 on 8.x-7.x authored by skyredwang
    Issue #2667922 by skyredwang: Remove Gemfile.lock and move "version lock...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.