Because the branch tests were failing, japerry removed PanelsTest:

http://cgit.drupalcode.org/panels/commit/?h=8.x-3.x&id=47b5c6af3d793c775...

Given our small amount of test coverage, this test is really valuable! Without it, we have no functional tests that actually use Panels.

So, let's get it passing again and add it back!

CommentFileSizeAuthor
#3 panels-restore-panels-test-2667648-3.patch3.56 KBjaperry
#2 panels-restore-panels-test-2667648-2.patch2.83 KBdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Active » Needs review
FileSize
panels-restore-panels-test-2667648-2.patch2.83 KB

Here's a patch that adds it back with the reference to page_manager_ui removed. Let's see what happens!

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Drupal Association commented
FileSize
panels-restore-panels-test-2667648-3.patch3.56 KB

try to see if this works with page manager head.

Status: Needs review » Needs work

The last submitted patch, 3: panels-restore-panels-test-2667648-3.patch, failed testing.

  • japerry committed b2a0fa3 on 8.x-3.x authored by dsnopek 
    Issue #2667648 by dsnopek, japerry: Add the PanelsTest back
japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Drupal Association commented
Status: Needs work » Fixed

well #3 didn't work. so we have #2. fixed.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented

Woohoo! Thanks :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.