Hi,

While accessing the eForm Submission, we got this Fatal Error. This is different error than the one listed in other issues.
Can you please resolve this asap?

Fatal error: Declaration of Drupal\eform\EFormSubmissionAccessControlHandler::access() must be compatible with Drupal\Core\Entity\EntityAccessControlHandlerInterface::access(Drupal\Core\Entity\EntityInterface $entity, $operation, Drupal\Core\Session\AccountInterface $account = NULL, $return_as_object = false) in C:\wamp\www\iimisac-d8\modules\eform\src\EFormSubmissionAccessControlHandler.php on line 17

Thanks
Ashish Naik

CommentFileSizeAuthor
#7 eform_removed_language_2667468_7_8.x-1.x-dev.patch2.91 KBsagesolutions
#3 eform_removed_language_2667468_3_8.x-1.x-dev.patch2.6 KBsagesolutions
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anaik created an issue. See original summary.

sagesolutions’s picture

sagesolutions CreditAttribution: sagesolutions commented

I am also having this error.

sagesolutions’s picture

sagesolutions CreditAttribution: sagesolutions commented
FileSize
eform_removed_language_2667468_3_8.x-1.x-dev.patch2.6 KB

The EFormSubmissionAccessControlHandler was updated and the Language stuff was removed. Attached is a patch that works for me.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Six Mile Tech commented

@sagesolutions thanks for the patch. It probably works but.... 

 .../contrib/eform/src/EFormSubmissionAccessControlHandler.php    | 9 ++++-----

The patch doesn't apply because it starts from ../contrib
could you please update the patch and I will commit it?

Patch handbook page https://www.drupal.org/node/707484

thanks

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Six Mile Tech commented
Status: Active » Needs work
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
CreditAttribution: tedbow at Six Mile Tech commented
Status: Needs work » Needs review

@sagesolutions I committed some changes to 8.x-1-dev can you check if the problem is fixed.

sagesolutions’s picture

sagesolutions CreditAttribution: sagesolutions commented
FileSize
eform_removed_language_2667468_7_8.x-1.x-dev.patch2.91 KB

Hi @tedbow,

I see that 1/2 of the patch was applied. I was still getting the strict warning issues, so I created another patch. It works for me, but please test.

Thanks!

P.S. my sublime text editor changed the spaces to tabs... I couldn't figure out how to undo that. sorry!

killua99’s picture

killua99 CreditAttribution: killua99 commented

@sagesolutions Read this post to setup right Sublime Text for Drupal Code Standard. https://www.drupal.org/node/1346890

Because is hard to follow the change.