Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Since I mostly want to add watermarks in proportion to the image size, it would be nice to be able to specify the offset in percentages. Since the sizing of the watermark is related to this (#2667184: Scale watermark image with reference to source image) applying this on both offset and the dimensions of the watermark would be great.
Comment | File | Size | Author |
---|---|---|---|
#19 | 2667188-19.patch | 29.57 KB | mondrake |
#19 | interdiff_17-19.txt | 2 KB | mondrake |
Comments
Comment #2
Lukas von BlarerIssue created by mistake and corrected accordingly.
Comment #3
Lukas von BlarerComment #4
mondrakeI suggest to wait for #2667572: Introduce a Form API element to manage entering information in pixel/percentage to deal with percentage offsets in a proper way. Percentage dimensions is taken care of in #2667184: Scale watermark image with reference to source image.
Comment #5
Lukas von BlarerMakes sense. Thank you!
Comment #6
mondrakeComment #7
mondrake#2667572: Introduce a Form API element to manage entering information in pixel/percentage has been committed, this can be worked on now.
Comment #8
mondrakeHere's a patch. It builds on top of #2715317: Add "Image mask" effect, since it basically aligns watermark to mask in terms of functionalities - resizing of watermark both horizontal and vertical, both per px or %, and offsets by px or %.
Would require an update function + tests since it changes the schema of the watermark effect.
Comment #10
mondrakeMissed --binary option for git diff
Comment #11
mondrakePostponed on #2715317: Add "Image mask" effect
Comment #12
mondrakeImage mask is in, unpostponed. Added post-update for the watermark effect + test.
Comment #14
mondrakeComment #15
mondrakeX and Y offsets can be negative.
Comment #17
mondrakeComment #18
mondrakeNW for the 7.1 failures
Comment #19
mondrakeFix of 7.1 failures
Comment #21
mondrakeCommitted.