Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi! I created a patch for 7.x-3.4 to allow to users to set theme-color tag (https://developers.google.com/web/updates/2014/11/Support-for-theme-colo...) for Chrome Android 39+ in theme settings.
will be possible to do a pull request for include this feature in next release? Thanks!!
Comment | File | Size | Author |
---|---|---|---|
#5 | bootstrap_theme_color.patch | 1.96 KB | sergiocarracedo |
Screenshot from 2016-02-11 17:58:55.png | 14.12 KB | sergiocarracedo | |
chrome-theme-color.patch | 2.36 KB | sergiocarracedo | |
Comments
Comment #2
markhalliwellMissing space and punctuation ending.
The setting name should reflect what this is, e.g. "meta_theme_color".
I'm not sure about adding a whole new fieldset for this.
This should reflect the property name, e.g. "Meta: Theme Color".
for colorize status bar un Chrome Android. See Theme Color', array(
+ '!url' => 'hhttps://developers.google.com/web/updates/2014/11/Support-for-theme-colo...',
"Provide a color hex value. This meta tag is used by Chrome on mobile devices to colorize the native UI tool/status bars. See this announcement for more details."
---
Generally speaking, I would say that this should be left for a sub-theme to implement as it's so esoteric in nature. I would also say that we shouldn't mention "Chrome" or "Android" specifically since I can also see the potential for this to eventually becoming adopted by other browsers/devices.
I still have to think about whether it's a good idea to implement this since I can see many people thinking that this would "theme" their actual site to this color (i.e. it's an unfortunate coincidence/property name).
Comment #3
markhalliwellAlso, 8.x-3.x is now HEAD... it will need to be implemented there first and then backported to 7.x-3.x.
Comment #4
sergiocarracedo CreditAttribution: sergiocarracedo commentedThanks for the quick reply. Ok, I try to implement same patch in 8.x-3.x. I will send patch when it's will be ready
Comment #5
sergiocarracedo CreditAttribution: sergiocarracedo commentedI created a patch for 8-x.3-x. I changed fieldgroup title from 'Theme' to 'Metas' to avoid confusion width theme
I know that this funcionality could get using metatag module and config a custon metatag, but i think is easier for users config the color in theme (or subtheme)
Thanks!
Comment #6
neardark CreditAttribution: neardark at Examiner.com commentedI tend to agree, I'm not sure this should be a setting in the Drupal Bootstrap subtheme. If we get a lot of requests for this, we'll consider adding.
Comment #7
markhalliwellI'd rather postpone this and see if it gets any more traction before out right refusing to add it. I'd hate to see the work @sergiocarracedo has done (for both branches btw) go unappreciated.
Comment #8
nikathoneFYI, the https://www.drupal.org/project/metatag module(D7 at least) allow you to add this through the UI
Comment #9
markhalliwellHm. Good point!
I'm really sorry @sergiocarracedo :( I just don't think this is going to happen after all.
Comment #10
sergiocarracedo CreditAttribution: sergiocarracedo commentedNo problem. I moved this feature to my own subtheme. Thanks for your time!