Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The @file boilerplate has been declared useless and we can now remove it as per coding standards.
#2304909: Relax requirement for @file when using OO Class or Interface per file
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2664316.patch | 153.31 KB | TR |
| |||
Comments
Comment #2
TR CreditAttribution: TR commentedThese sorts of changes wouldn't annoy me if they took the time to fix core to keep up with the ever-changing standards. There are core coding-standards patches that have been around > 5 YEARS to fix a bunch of these things (I know - I submitted some of them), but getting them committed is harder than getting an entire core module re-write committed. It's the definition of bike-shedding. The fact is that core will NEVER be up to the coding standards and no core committer really cares.
Now in the interest of "saving time" by not requiring an extra line at the top of each file, they force contrib developers to spend hours changing their code again and again, while happily ignoring these things in core. We have almost FOUR HUNDRED files that now have to be changed! And if we don't then the coder module will spit out hundreds of complaints about Ubercart not being compliant with coding standards.
Comment #3
longwaveThe @file directive will be optional so it's not so bad. There is also an initiative to get coding standards fixed in core and checks run against patches to try and avoid this in the future. I just think it's not top of everyone's list of things to do really!
Comment #4
TR CreditAttribution: TR commentedActually, this is flagged as an ERROR by the coding standards, even though it's supposed to be optional. But now with phpcs and phpcbf, it's not a hard patch to make. So let's try this:
Comment #6
TR CreditAttribution: TR commented