In system_schema() we create a semaphore table. We should change Drupal\Core\Lock\DatabaseLockBackend to only create a table if necessary - this means that alternate lock implementations can safely remove the semaphore table and know that if the site swaps back to the DatabaseLockBackend the table will be created.

Also making this change encapsulates the storage to the backend which is good for general sanity.

CommentFileSizeAuthor
#2 2664302-2.patch9.54 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Active » Needs review
FileSize
2664302-2.patch9.54 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Looks reasonable for me.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs review

sqlite isn't happy. Sending for re-test.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Seems fine now and I can't see how the simpletest https test is related to this so back to rtbc.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

I think before we commit anymore of these we need to have a think about #2664466-12: url_alias table is only used by a core service but it depends on system install if this fails in the middle of a postgres transaction we've got a problem

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Postponed
Related issues: +#2487269: Postgres insert queries that fail in a transaction break the entire transaction

Postponing on #2487269: Postgres insert queries that fail in a transaction break the entire transaction.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Postponed » Reviewed & tested by the community

#2487269: Postgres insert queries that fail in a transaction break the entire transaction got committed so back to rtbc as per #3

  • catch committed 9de3594 on 8.1.x 
    Issue #2664302 by alexpott: Semaphore table is only used by a core...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.