Follow-up to #2281763: Make Drupal.org user profiles more robust

Remove the sandbox projects from the projects listing on the profile.

Question: From where this project listing is printed on the project.

CommentFileSizeAuthor
#15 drupal-org-user-profile-light-grey.png238.94 KBnaveenvalecha
#15 drupal-org-user-profile-dark-grey.png218.3 KBnaveenvalecha
#15 2664154-15-light-grey.patch466 bytesnaveenvalecha
#15 2664154-15-dark-grey.patch465 bytesnaveenvalecha
#13 2664154-13.patch432 bytesnaveenvalecha
#9 Screen Shot 2016-03-01 at 10.22.08.png125.8 KBnaveenvalecha
#9 interdiff-2644154-6-8.txt906 bytesnaveenvalecha
#9 2644154-8.patch1.21 KBnaveenvalecha
#8 Screen Shot 2016-03-01 at 10.05.58.png48.65 KBnaveenvalecha
#7 2664154-6.patch1.25 KBnaveenvalecha
user-profile-projects-listing.png220.55 KBnaveenvalecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Project: Drupal.org customizations » Version Control / Project* integration
Version: 7.x-3.x-dev » 7.x-1.x-dev
Component: User profiles » Code

This is rendered in versioncontrol_project_user_view(). (I wouldn't mind moving this to drupalorg module, so it might be merged with issue credits.)

Since we still have the project application process, many developers are limited to sandboxes only. I think we should keep the sandbox commits, and clearly emphasize the full projects.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented

This is rendered in versioncontrol_project_user_view(). (I wouldn't mind moving this to drupalorg module, so it might be merged with issue credits.)

+1 but that we can do in followup later after this gets in.

I think we should keep the sandbox commits, and clearly emphasize the full projects.

Any thoughts ? any rough plan/sketch for the implementation.

I believe we have the https://www.drupal.org/project/user page for sandbox projects and user full projects.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented

Maybe simply change the link color from blue to grey for the sandbox projects?

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented

Maybe simply change the link color from blue to grey for the sandbox projects?

+1 Do you know any grey color class ?

Why not we completely remove the sandbox projects from this listing from main profile page and point it to a new page where all projects will be listed first sandbox with commits then full projects with commits ? like https://www.drupal.org/project/user
For long term when we only 2-3 projects and then we can use this new page. Thoughts ?

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented

Let's add a project-type-{t.field_project_type_value} class and then move this issue over to bluecheese to style it.

https://www.drupal.org/project/user/{uid} is indeed available for everyone to view, but I'd rather keep this simple and not get into the user page navigation changes right now. That page also doesn't show the number of commits.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Status: Active » Needs review
FileSize
2664154-6.patch1.25 KB

Well let's stick with the scope of this issue.Will post my comments in meta/plan/discussion issue.
Posting untestable patch. Need a dev site for testing this, if you have already setup site, lemme know, I had one dev d.o. site but I forget now which was that

Adding a single class for sandbox projects only; we don't need any class for full projects so let's them use the existing css.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
FileSize
Screen Shot 2016-03-01 at 10.05.58.png48.65 KB

Now we have a class project-type-sandbox for the sandbox projects on the profile.
Screenshot attached.
Next step : after committing this patch in this repo we move the issue to bluecheese as drumm said.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
FileSize
2644154-8.patch1.21 KB
interdiff-2644154-6-8.txt906 bytes
Screen Shot 2016-03-01 at 10.22.08.png125.8 KB

Added a project-type-{t.field_project_type_value} class so that later we can style full projects as well.

Attached screenshot of profile with grey color on sandbox projects.

  • drumm committed a3f7085 on 7.x-1.x authored by naveenvalecha 
    Issue #2664154 by naveenvalecha: Add project type classes to listing on...
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Project: Version Control / Project* integration » Bluecheese
Status: Needs review » Active

Looks good, committed with a bit of code shortening. Moving to bluecheese for the CSS style.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Related issues: +#2677620: Need a development drupal.org site for #2664154

cool

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Status: Active » Needs review
Issue tags: +Needs screenshots
FileSize
2664154-13.patch432 bytes
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented

The dev site for this was lost due to filesystem issues. This is far enough along that testing with your favorite browser’s developer tools will work well. The remaining things to get right are:

  • Make sure this is in the best partial. I think sass/partials/common/_user-profile.scss makes the most sense.
  • Make sure this has enough contrast from the white background.
naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented
Issue tags: -Needs screenshots
FileSize
2664154-15-dark-grey.patch465 bytes
2664154-15-light-grey.patch466 bytes
drupal-org-user-profile-dark-grey.png218.3 KB
drupal-org-user-profile-light-grey.png238.94 KB

#14.1 Done
#14.2 Dark grey screenshots looks good to me.

DyanneNova’s picture

DyanneNova
she/her
CreditAttribution: DyanneNova at Drupal Association commented
Status: Needs review » Needs work

I don't think differently colored links are going to be clear to most users. Greying the link out makes it seem like clicking is disabled. It doesn't say anything about it being a sandbox.

Why not move the sandboxes out of the main list and below full projects?

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia commented

Why not move the sandboxes out of the main list and below full projects?

Nice idea, but for full listing we have https://www.drupal.org/project/user

See #4, about the color change of sandbox issue.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Title: Remove sandbox projects from the projects listing on the profile » Disinguish sandbox projects on the projects listing on the profile

A separate heading would bring more attention to the sandboxes, while I think naveenvalecha’s goal is to de-emphasize them. I’ve answered enough support requests about sandbox credit, removing the credit wouldn’t be a good option.

naveenvalecha - sandboxes are meant to be ephemeral, I think you could just delete any you no longer want.