Coder fixes http://pareview.sh/pareview/httpgitdrupalorgprojectgooglecurrencyconvert...

CommentFileSizeAuthor
#10 2664114-10.patch2.54 KBfelribeiro
#8 2664114-8.patch2.54 KBfelribeiro
#2 2664114.patch4.83 KBnaveenvalecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Active » Needs review
FileSize
2664114.patch4.83 KB

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs review » Fixed

pushed and committed.

Status: Fixed » Needs work

The last submitted patch, 2: 2664114.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Needs work » Active

Opening this for 7.x
http://pareview.sh/pareview/httpgitdrupalorgprojectgooglecurrencyconvert...

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Issue tags: +Quickfix
felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
Status: Active » Needs review
FileSize
2664114-8.patch2.54 KB

Status: Needs review » Needs work

The last submitted patch, 8: 2664114-8.patch, failed testing.

felribeiro’s picture

felribeiro CreditAttribution: felribeiro at CI&T commented
Status: Needs work » Needs review
FileSize
2664114-10.patch2.54 KB

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer and at Acquia for Acquia commented
Status: Needs review » Fixed

Pushed and committted.
Thanks!
http://pareview.sh/pareview/httpgitdrupalorgprojectgooglecurrencyconvert...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.