google_currency_converter_form : There are two same id attribute on two select list(google_currency_converter_from, google_currency_converter_to) use a common class instead for all elements

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

sdstyles’s picture

Status: Needs review » Needs work

The last submitted patch, 2: use-class-attribute-2664102-2.patch, failed testing.

sdstyles’s picture

Status: Needs work » Needs review
naveenvalecha’s picture

Thanks! we are near to fix this.we also need to change in textfield.

+++ b/google_currency_converter.css
@@ -1,4 +1,4 @@
+.google-currency-converter-select {

Make it .google-currency-converter-element and use for both select list and textfield

naveenvalecha’s picture

Status: Needs review » Needs work
sdstyles’s picture

Status: Needs work » Needs review
FileSize
1.48 KB
1.31 KB

Fixed

Status: Needs review » Needs work

The last submitted patch, 7: use-class-attribute-2664102-7.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Needs review
FileSize
1.88 KB

I'm in favour or merging the #google-currency-converter-textfield and #google-currency-converter-select into .google-currency-converter-element

naveenvalecha’s picture

Status: Needs review » Fixed

Committed. THanks

Status: Fixed » Needs work

The last submitted patch, 9: 2664102-8.patch, failed testing.

naveenvalecha’s picture

Status: Needs work » Fixed

testbot fluke

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.