Problem/Motivation

We need to validate the import before doing the import. At the moment a broken import will just crash the installer.

Proposed resolution

Move validation from SyncConfigureForm::submit() to SyncConfigureForm::validate() and extend it to call ConfigImporter::validate().

Remaining tasks

User interface changes

New error messages if there is something wrong with your configuration.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 2-3-interdiff.txt531 bytesalexpott
#3 2663386.3.patch17.88 KBalexpott
#2 2663386.2.patch17.89 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Issue summary: View changes
Priority: Normal » Critical
Status: Active » Needs review
FileSize
2663386.2.patch17.89 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2663386.3.patch17.88 KB
2-3-interdiff.txt531 bytes

Minor improvement

  • alexpott committed 4e208b0 on 8.x-1.x 
    Issue #2663386 by alexpott: Validate the incoming in during form...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.