Module violates Drupal coding standards

+1

In addition to the code itself, the branch naming convention that you're using is somewhat broken. The convention for all "development" branches for Drupal 7 should be "7.x-2.x". Git's default "master" branch should not be used, so I suggest you merge your changes back into "7.x-2.x" and continue development from there. Additionally, you have a Branch called 7.x-2.6 AND you have a Tag called 7.x-2.6. This ambiguity causes refname conflicts in Git.

Please have a look at this link which discusses how to name Git branches according to the Drupal.org convention.
https://www.drupal.org/node/1015226

Hi,

I have created resolved all Coding standard fixes for the Mailjet module. Attached Patch file of code documented for this module excepts below 2 files.

1) mailjet_list_plugin_style.inc

FILE: ...modules/list/includes/views/plugins/mailjet_list_plugin_style.inc
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 11 | ERROR | Class name must begin with a capital letter
 11 | ERROR | Class name must use UpperCamel naming without underscores
 16 | ERROR | Public method name "views_plugin_mailjet_list::option_definition" is not in lowerCamel format
 26 | ERROR | Public method name "views_plugin_mailjet_list::options_form" is not in lowerCamel format
----------------------------------------------------------------------

The plugin class is extended from "views_plugin_style" class from views module. So we can't change the overriding the function names in sub/child class.

2. mailjet.api.inc

FILE: /home/innoppl/Arun/Others/MYPROJECT/Mailjet/mailjet.api.inc
----------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------
 239 | ERROR | Type hint "array" missing for $params
 585 | ERROR | Type hint "array" missing for $params
 623 | ERROR | Type hint "array" missing for $params
 658 | ERROR | Type hint "array" missing for $args
 699 | ERROR | Type hint "array" missing for $params
 746 | ERROR | Type hint "array" missing for $params
 865 | ERROR | Type hint "array" missing for $params
----------------------------------------------------------------------

This is the problem in coder module. Please refer [policy, no patch] Add parameter type hinting to function declaration coding standards and PHP_Codesniffer flagging 'Type hint "array" missing...' but type hints not a standard

For naming conventional you can find Release naming conventions or On project page Edit > Releases > Add new release (https://www.drupal.org/node/add/project-release/1319774 this URL only accessible for module maintainers)

Thanks & Regards,
Arunkumar K

Hello all,

We have released a new beta version of the Mailjet plugin with improvements in the code style.
You can get version 7.x-2.16-beta1 from here: https://www.drupal.org/project/mailjet/releases

Please let us know if you encounter some problems with it.

Best regards,
Mailjet Plugins Team