in 7.x-2.x the logic is being held in pmpermission submodule. Move those logic involving relationship like Project belongs to Organizations and Issues belongs to Projects into core Drupal PM module.

I see that PM Permission no longer shows in the module list /admin/modules

I enabled and spotchecked all the modules

As far as I can tell PM works the way it did before.

Comments

D34dMan created an issue. See original summary.

D34dMan’s picture

D34dMan CreditAttribution: D34dMan as a volunteer and commented
Status: Active » Needs review

  • D34dMan committed 157614a on 7.x-3.x 
    Issue #2661660: Move pmpermission logic into core
dbt102’s picture

dbt102 CreditAttribution: dbt102 commented

I've pulled this down via git and installed to review. It looks ok to me, but I'm not exactly sure how to test the work of this last 157614a commit. Any guidance?

D34dMan’s picture

D34dMan CreditAttribution: D34dMan as a volunteer and commented

While using and configuring permissions used by pm, you should not be able to see/feel any difference :). The permission names are same. Only the implementing module have changed. Also pmpermission should no longer be needed. Since everything that was in pmpermission is in pm module now.
---
NOTE: above is a copy paste from private mail i send

dbt102’s picture

dbt102 CreditAttribution: dbt102 commented
Issue summary: View changes

Thanks, that was helpful. I see now how pmpermission module is being deprecated (by comparing the files pmpermission/pmpermission.module of the old and new, and others as well). This changes the layout of PM Permissions @ /admin/people/permissions also.

dbt102’s picture

dbt102 CreditAttribution: dbt102 commented
Status: Needs review » Reviewed & tested by the community
D34dMan’s picture

D34dMan CreditAttribution: D34dMan as a volunteer and commented
Issue tags: +Needs documentation

I see now how pmpermission module is being deprecated

pmpermission is obsolete in 7.x-3.x because it will be in pm (core module).

This changes the layout of PM Permissions @ /admin/people/permissions also.

I missed this one. Yeah, it should be now under different heading as the module implementing it has changed. Should be mentioned in release notes.

juliangb’s picture

juliangb CreditAttribution: juliangb as a volunteer commented

I had thought that this issue related to simply moving the logic of finding parents into pm, but I see instead the whole module has moved! I think I agree with this direction, but will have a think!

I need to try the latest 3.x anyway as have been offline for a while.

juliangb’s picture

juliangb CreditAttribution: juliangb as a volunteer commented

A really minor thing is that I'd suggest the path of the settings page could be admin/config/pm/permissions instead of admin/config/pm/pm_permission.

It just reads a little more cleanly.

I realise this isn't proper namespacing, but we don't have the pm prefix for other config pages at the moment so I'd say that extra namespacing isn't required here.

juliangb’s picture

juliangb CreditAttribution: juliangb as a volunteer commented

Changed paths as part of #2703049: Structure configuration pages.

Leaving this open as per the documentation tag.

I'm liking the permissions as part of pm core, it makes sense I think and is simpler for users configuring pm for the first time.

juliangb’s picture

juliangb CreditAttribution: juliangb as a volunteer commented
Title: Move Logic involving relationship between different Project Management entities into PM (core module). » Move PM Permission into PM (core module).

Changing title to reflect actual changes.

juliangb’s picture

juliangb CreditAttribution: juliangb as a volunteer commented
Status: Reviewed & tested by the community » Needs work

NW for documentation only.

D34dMan’s picture

D34dMan CreditAttribution: D34dMan as a volunteer and commented
Assigned: D34dMan » Unassigned
Issue tags: +low hanging fruit

  • juliangb committed 4bd012a on 7.x-3.x 
    Issue #2661660: Move PM Permission into PM (core module) - documentation
juliangb’s picture

juliangb CreditAttribution: juliangb as a volunteer commented
Status: Needs work » Fixed
Issue tags: -Needs documentation, -low hanging fruit

Documentation is done.

juliangb’s picture

juliangb CreditAttribution: juliangb as a volunteer commented
Status: Fixed » Needs work

@D34dMan - any reason why I shouldn't remove the PM Permission folder (contains stub of hidden module) as well?

D34dMan’s picture

D34dMan CreditAttribution: D34dMan as a volunteer and commented

Some people upgrade the modules by downloading it in ftp and pushing it to server. When such upgrade is done, and pmpermission folder is missing in the new version, it doesn't get removed. The module stays as it is and will be available in the module administration page, albeit an old version, an unintentional consequence. So thats the reason why the stub was created.

We can remove the stub, if we make sure the people who are upgrading Drupal PM removes/deletes the folder manually.

juliangb’s picture

juliangb CreditAttribution: juliangb as a volunteer commented
Status: Needs work » Fixed

That's a good idea - let's keep it.

  • D34dMan committed 157614a on 8.x-1.x 
    Issue #2661660: Move pmpermission logic into core
  • juliangb committed 4bd012a on 8.x-1.x
    Issue #2661660: Move PM Permission into PM (core module) - documentation

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.