Problem/Motivation

Putting a lot of files into the same directory is bad for file system performance.

Proposed resolution

Support tokens in the upload_location field, just like a file field.

Also, I think it makes sense to adopt the file field default, which uses the year and month as default location.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 dropzonejs-token-upload-location-2661402-6.patch4.17 KBtduong
#6 interdiff-2661402-4-6.txt1.28 KBtduong
#4 dropzonejs-token-upload-location-2661402-4.patch3.79 KBtduong
#4 interdiff-2661402-1-4.txt2.51 KBtduong
#2 dropzonejs-token-upload-location-2661402-1.patch1.75 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
dropzonejs-token-upload-location-2661402-1.patch1.75 KB
Primsi’s picture

Primsi CreditAttribution: Primsi at Examiner.com for Examiner.com commented
Status: Needs review » Needs work 
+++ b/src/DropzoneJsUploadSave.php
@@ -100,6 +101,10 @@ class DropzoneJsUploadSave implements DropzoneJsUploadSaveInterface {
+    $destination = PlainTextOutput::renderFromHtml(\Drupal::token()->replace($destination));

Inject the token service?

Otherwise looks fine.

tduong’s picture

tduong CreditAttribution: tduong at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
interdiff-2661402-1-4.txt2.51 KB
dropzonejs-token-upload-location-2661402-4.patch3.79 KB

Added token service injection.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Needs work 
+++ b/src/DropzoneJsUploadSave.php
@@ -83,14 +93,26 @@ class DropzoneJsUploadSave implements DropzoneJsUploadSaveInterface {
+  public static function create(ContainerInterface $container) {
+    return new static(
+      $container->get('token')
+      );

You don't need this. You need to add it to dropzonejs.services.yml instead.

tduong’s picture

tduong CreditAttribution: tduong at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
interdiff-2661402-4-6.txt1.28 KB
dropzonejs-token-upload-location-2661402-6.patch4.17 KB

Done.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Looks good to me now but haven't tested.

  • Primsi committed 6dba258 on 8.x-1.x 
    Issue #2661402 by tduong, Berdir, Primsi: Support tokens in...
Primsi’s picture

Primsi CreditAttribution: Primsi at Examiner.com for Examiner.com commented
Status: Needs review » Fixed

Tested it, looks fine. Thanks all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.