Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.OpenIDTestCase::testConversion() compares numeric strings incorrectly.
In 5.3 and below, the conversion behaves differently than in 5.4+.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2660754-4.patch | 2 KB | twistor |
Comments
Comment #2
twistor CreditAttribution: twistor as a volunteer commentedTest to illustrate the problem.
Comment #3
twistor CreditAttribution: twistor as a volunteer commentedComment #4
twistor CreditAttribution: twistor as a volunteer commentedComment #6
twistor CreditAttribution: twistor as a volunteer commentedThose 5.4 failures don't make any sense.
Comment #7
twistor CreditAttribution: twistor as a volunteer commentedI wonder how many failures there will be this time.
Comment #8
twistor CreditAttribution: twistor as a volunteer commentedComment #9
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedI tried to figure out if historically there was some reason they expected the actual output to be
'09876...'rather than'9876...'but couldn't find one. So I guess it was just a bug in the test and it should have been checking for'9876...'all along.Therefore, marking this RTBC - thanks!
Comment #10
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedRTBC + 1, Marking for commit.
Comment #12
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commentedCommitted and pushed to 7.x! Thanks!
Giving credit to David for his research.
Comment #13
Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented