Latest commit on oa_print was 70eb87d.
Since initial release oa_print had the download of the dompdf library (dompdf 0.6.0 beta 3) hardcoded into oa_print.make file.
The dompdf 0.6.0 beta 3 library was released on August, 14th 2013 and, although superseded by actual stable dompdf 0.6.2, it still is available at reported URL for download by the Open Atrium Print Module oa_print.make file.
Actually dompdf library is hosted on http://dompdf.github.io/ (as advised on its historical page on code.google.com) and its latest stable release - dompdf 0.6.2 - was released on December, 7th 2015.
It is available here:
https://packagist.org/packages/dompdf/dompdf#v0.6.2
Full beta/stable release history is available here:
https://github.com/dompdf/dompdf/releases
The dompdf 0.6.2 stable release is available here:
https://github.com/dompdf/dompdf/releases/tag/v0.6.2
Some Low/Medium Security issues were resolved (some of which may be Critical depending on configuration) and many improvements/bug fixes were introduced since dompdf 0.6.0 beta 3.
Question: wouldn't be nice to have Atrium Print updated to reference to dompdf 0.6.2 instead of dompdf 0.6.0 beta 3?
Is it a matter of changing the oa_print module library download URL from:
libraries[dompdf][download][url] = http://dompdf.googlecode.com/files/dompdf_0-6-0_beta3.tar.gz
to (if the zip file format is acceptable):
libraries[dompdf][download][url] = https://github.com/dompdf/dompdf/releases/download/v0.6.2/dompdf-0.6.2.zip
or to (if Source Code is necessary):
libraries[dompdf][download][url] = https://github.com/dompdf/dompdf/archive/v0.6.2.tar.gz
or there are other requirements (testing compatibility apart)?
Comments
Comment #2
dpoletto CreditAttribution: dpoletto commentedComment #3
dpoletto CreditAttribution: dpoletto commentedIs anybody able to evaluate if OA Print can be updated to use the actual dompdf 0.6.2 (Stable) library easily and, if so, a new version of OA Print Module can be ready in time for next Atrium 2.60 release? Would be great.
Comment #4
dpoletto CreditAttribution: dpoletto commentedComment #5
oxygenliu CreditAttribution: oxygenliu commentedI changed the make file: libraries[dompdf][download][url] = https://github.com/dompdf/dompdf/releases/download/v0.6.2/dompdf-0.6.2.zip, but no luck.
Anyone succeed with 0.6.2 stable?
Comment #6
dpoletto CreditAttribution: dpoletto commentedWas that changed on git (oa_print)?
Comment #7
dpoletto CreditAttribution: dpoletto commentedOn May, 11st dompdf 0.7.0 was released as new Stable: https://github.com/dompdf/dompdf/releases/tag/v0.7.0
Comment #8
Argus CreditAttribution: Argus as a volunteer commentedDidn't update the Issue summary but this seems a reasonable request?
Comment #9
dpoletto CreditAttribution: dpoletto commented@Argus: you're right, I missed to update the title and Plan is better than Support Request as categorization. Thanks you.
Comment #10
dpoletto CreditAttribution: dpoletto commentedUpdate: as recently reported on the Ticket 2794959 the (old) hard-coded dompdf 0.6.0 beta 3 library is not available anymore at reported URL for download by the Open Atrium Print Module oa_print.make file.
Comment #11
mpotter CreditAttribution: mpotter commentedPatches for this would be welcome. The OA Print module is not enabled by default and not something we regularly test. It was just something done for a client long ago and doesn't get a lot of attention. So I really rely on the community to help with this one.
Last time I looked at this it seems like there was an issue in the version of the Print module being used, so that might need to be updated also.