Problem/Motivation

#1808810: Remove handling of moved tables removed the code that handles moved fields/tables.
However, the code within views plugins that responds to them is still leftover.
It is stale code that will never run.

Proposed resolution

Remove actualField and actualTable, both the public properties and the 3 lines for each in \Drupal\views\Plugin\views\HandlerBase::init()

Remaining tasks

User interface changes

N/A

API changes

These are public properties, so backwards compatibility is questionable here.

Data model changes

N/A

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett created an issue. See original summary.

lluvigne’s picture

Status: Active » Needs review
FileSize
1.37 KB

Hi,
i've removed this public properties and the code relating to this properties on \Drupal\views\Plugin\views\HandlerBase::init().

Regards!

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Perfect, thanks!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Stale code just adds confusion and complexity. Views is complex enough. Committed f2fe78a and pushed to 8.1.x. Thanks!

  • alexpott committed f2fe78a on 8.1.x
    Issue #2659986 by lluvigne: Remove \Drupal\views\Plugin\views\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.