The patch in #2650302-7: acl_save_form insert query optimization is failing and looking into it reveals that the branch fails, even though we didn't have any commit in the meantime. So, apparently, Core has changed...

... but we need to adjust, of course.

CommentFileSizeAuthor
#12 2659944-12.patch10.73 KBnaveenvalecha
#10 2659944-10.patch0 bytesnaveenvalecha
#8 2659944-8.patch2.34 KBnaveenvalecha
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

salvis created an issue. See original summary.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Title: Test failures » Test failure: Adjust namespace for MigrateDrupal6TestBase base class for D81

https://dispatcher.drupalci.org/job/default/127977/console shows

PHP Fatal error: Class 'Drupal\migrate_drupal\Tests\d6\MigrateDrupal6TestBase' not found in /var/www/html/modules/acl/src/Tests/Migrate/d6/MigrateAclListTest.php on line 20

It turns out that the correct namespace changed from D80's
Drupal\migrate_drupal\Tests\d6\MigrateDrupal6TestBase
to
Drupal\Tests\migrate_drupal\Kernel\d6\MigrateDrupal6TestBase
in D81.

  • salvis committed 2bf9c2c on 8.x-1.x 
    Issue #2659944 by salvis: Test failure: Adjust namespace for...

  • salvis committed 1f94082 on 8.x-1.x 
    Issue #2659944 by salvis: Test failure: Adjust namespace for...

  • salvis committed 8f96db6 on 8.x-1.x 
    Issue #2659944 by salvis: Test failure: Adjust namespace for...

  • salvis committed 4002405 on 8.x-1.x 
    Issue #2659944 by salvis: Test failure: Adjust more namespaces for D81.
salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Assigned: Unassigned » id.tarzanych

Please take a look at this, I don't get what the problem is...

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia for Acquia commented
Status: Active » Needs review
FileSize
2659944-8.patch2.34 KB

Here's the start

Status: Needs review » Needs work

The last submitted patch, 8: 2659944-8.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia for Acquia commented
Status: Needs work » Needs review
FileSize
2659944-10.patch0 bytes

Status: Needs review » Needs work

The last submitted patch, 10: 2659944-10.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha at Acquia for Acquia commented
Status: Needs work » Needs review
FileSize
2659944-12.patch10.73 KB

Here's the start of kernel tests. The patch will fail will debug it later after sometime. In the meanwhile If someone wants to pick ? go ahead

Status: Needs review » Needs work

The last submitted patch, 12: 2659944-12.patch, failed testing.

  • 7bba6c1 committed on 8.x-1.x 
    Issue #2659944 by salvis: Test failure: Yet another attempt...
salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs work » Fixed

Well, at least the namespace issue was fixed with #14.

@naveenvalecha: Too bad this didn't work out. Please start a new issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.