CommentFileSizeAuthor
#6 time_spent-porting_js_alternative_to_d8-2-8.x-1.x.patch6.72 KBpiyuesh23
#2 time_spent-porting_js_alternative_to_d8-2-8.x-1.x.patch6.85 KBpiyuesh23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

piyuesh23 created an issue. See original summary.

piyuesh23’s picture

piyuesh23 CreditAttribution: piyuesh23 at QED42 commented
Status: Active » Needs review
FileSize
time_spent-porting_js_alternative_to_d8-2-8.x-1.x.patch6.85 KB

Ported the patch to D8. Uploading the updated patch.

AjitS’s picture

AjitS
he/him
Primary language Marathi
Location Pune
CreditAttribution: AjitS as a volunteer and at QED42 commented
Status: Needs review » Needs work

Too many tabs!

AjitS’s picture

AjitS
he/him
Primary language Marathi
Location Pune
CreditAttribution: AjitS as a volunteer and at QED42 commented
Issue tags: +SprintWeekend2016

The last submitted patch, 2: time_spent-porting_js_alternative_to_d8-2-8.x-1.x.patch, failed testing.

piyuesh23’s picture

piyuesh23 CreditAttribution: piyuesh23 at QED42 commented
FileSize
time_spent-porting_js_alternative_to_d8-2-8.x-1.x.patch6.72 KB

Weird. Seems like my editor went crazy with JS indentation.

Uploading another patch.

piyuesh23’s picture

piyuesh23 CreditAttribution: piyuesh23 at QED42 commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: time_spent-porting_js_alternative_to_d8-2-8.x-1.x.patch, failed testing.

  • piyuesh23 committed e0b5180 on 
    Issue #2659428 by piyuesh23: Port https://www.drupal.org/node/2272681 to...
piyuesh23’s picture

piyuesh23 CreditAttribution: piyuesh23 at QED42 commented
Status: Needs work » Closed (fixed)

Tests failing due to missing tests on 8.x branch. Committing the fix to 8.x-1.x branch.

Closing this & creating another one to track tests.