I don't know what the 'invoice' context of the 'show' key in hook_uc_order_pane() maps to in the new plugin ... uc_fulfillment is the only module that uses it.

There's no real way to test this yet - the module doesn't work and there are no test cases. But it's a first step.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TR created an issue. See original summary.

TR’s picture

Forgot to include the plugin in the patch ...

longwave’s picture

The 'invoice' key is a historical relic that never worked - I think the original idea was to have order panes also generate parts of the invoice. This was then removed in the 7.x dev cycle, this instance must have been missed.

  • TR committed 108ec9d on 8.x-4.x
    Issue #2659278 by TR: Convert fulfillment order pane into plugin
    
TR’s picture

Status: Needs review » Fixed

I committed this. We won't really know if it works until the rest of the module gets ported, so that's what I'll work on.

TR’s picture

I did find a bug now that my port of uc_fulfillment is far enough along for testing. I committed a fix, now it's officially working.

  • TR committed 7c895e1 on 8.x-4.x
    Issue #2659278 by TR: Convert fulfillment order pane into plugin. Fix...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.