Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yvesvanlaer created an issue. See original summary.

DamienMcKenna’s picture

Did you set the Metatag field to be translated?

yvesvanlaer’s picture

I have everything enabled when it comes to translations:
- Configuration Translation
- Content Translation
- Interface Translation
- Language

When it comes to Metatag, I already tried using the "translate" button in the metatag config overview.
The metatag needs to get the translated body field :-).

Right now I'm using:
description: [node:summary]
og_description: [node:summary]

1mundus’s picture

I have the same problem with front page metatags. I'm using two languages and only the default language is recognized. When I switch to non-default language, it doesn't use the translation, but the default language is used instead.

My meta tags are manually inserted strings, there are no tokens involved.

Drupal version: 8.0.3
Metatags version: beta4

mr.baileys’s picture

Status: Active » Needs review
Issue tags: +Needs tests
FileSize
2.34 KB

Tokens are replaced language-unaware, attached patch should fix the issue by passing the active language to the token replacement logic. Still needs tests though.

DamienMcKenna’s picture

Nice! I'll review it soon.

DamienMcKenna’s picture

Status: Needs review » Needs work

Still needs tests ;)

mr.baileys’s picture

The last submitted patch, 8: default_metatags_are-2658242-8-test-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 8: default_metatags_are-2658242-8.patch, failed testing.

The last submitted patch, 8: default_metatags_are-2658242-8-test-only.patch, failed testing.

The last submitted patch, 8: default_metatags_are-2658242-8.patch, failed testing.

The last submitted patch, 8: default_metatags_are-2658242-8.patch, failed testing.

The last submitted patch, 8: default_metatags_are-2658242-8.patch, failed testing.

mr.baileys’s picture

I thought the test failures might be related to the fact that the testbot tests with Drupal Core 8.1.x, but tests are running fine with 8.1.x on my local machine too, so not sure what is causing it to fail on the testbot.

mr.baileys’s picture

So... test were failing since I committed requests to my local dev machine as part of the URL's used in the tests...

The last submitted patch, 16: default_metatags_are-2658242-16-test-only.patch, failed testing.

The last submitted patch, 16: default_metatags_are-2658242-16-test-only.patch, failed testing.

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed. Thanks again mr.baileys!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.