Replace deprecated usage of db_delete with a Connection::delete.

CommentFileSizeAuthor
#2 2657458-2.patch2.63 KBheykarthikwithu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
CreditAttribution: heykarthikwithu as a volunteer and at Valuebound commented
Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
FileSize
2657458-2.patch2.63 KB
mikemiles86’s picture

mikemiles86
he/him
CreditAttribution: mikemiles86 as a volunteer commented
Issue tags: +SprintWeekend2016, +SprintWeekendBOS
mikemiles86’s picture

mikemiles86
he/him
CreditAttribution: mikemiles86 as a volunteer commented
Assigned: Unassigned » mikemiles86
mikemiles86’s picture

mikemiles86
he/him
CreditAttribution: mikemiles86 as a volunteer commented
Assigned: mikemiles86 » Unassigned
Status: Needs review » Reviewed & tested by the community

Applied patch to the 8.x-3.x-dev branch.

- Confirmed the removal/replacement of all instances of db_delete().
- Ran all Tests to confirm they still passed
- Manually tested adding/removing panels pane.

all works as expected.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Drupal Association commented

Sub-issue / task of #2664792: Read through left-over D7 code, make issues for unimplemented features, and delete it!

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Drupal Association commented
Status: Reviewed & tested by the community » Closed (won't fix)

Marking this as won't fix. These issues will be tackled when the module itself is ported. Committing this patch does little to nothing for making these components work in D8. In fact some of the references aren't even called anymore.