Remove unused imports in the code base

CommentFileSizeAuthor
#8 remove_unused_imports-2657332-8.patch3.35 KBhussainweb
#2 2657332-2.patch3.42 KBheykarthikwithu

Comments

heykarthikwithu created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Active » Needs review
StatusFileSize
new 2657332-2.patch3.42 KB
hussainweb’s picture

hussainweb
Primary language English
commented

Thanks for this but my guess is with the refactoring going on, there will be a lot more imports we can remove. I would suggest doing this at the end when we are ready for a beta or final.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented

SHIZZLE :)

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Issue tags: +Quick fix
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Priority: Normal » Minor
Issue tags: -Quick fix +Quickfix
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Doesn't apply anymore.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new remove_unused_imports-2657332-8.patch3.35 KB

I couldn't get an interdiff because it would have been more work to reroll the old patch. I just ran it through PHPStorm's optimize imports feature. I think the patch is still small enough to review.

  • Berdir committed 1360c24 on 8.x-1.x authored by heykarthikwithu 
    Issue #2657332 by heykarthikwithu, hussainweb: Remove unused imports in...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.