responsive_tables_filter_preprocess_page() would be a bit faster if the presence of "<table" was tested with strpos() instead of preg_match().

CommentFileSizeAuthor
#2 responsive_tables_filter-remove_preg_replace-2657200-2-D7.patch948 bytesLiam Morland
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Liam Morland created an issue. See original summary.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Assigned: Liam Morland » Unassigned
Status: Active » Needs review
FileSize
responsive_tables_filter-remove_preg_replace-2657200-2-D7.patch948 bytes

Status: Needs review » Needs work

The last submitted patch, 2: responsive_tables_filter-remove_preg_replace-2657200-2-D7.patch, failed testing.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Issue summary: View changes
Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Issue summary: View changes
Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Status: Needs work » Needs review

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
CreditAttribution: mark_fullmer as a volunteer commented
Status: Needs review » Fixed

Interesting chart of how the two operations match up, here: https://lzone.de/articles/php-string-search.htm

All Behat tests pass on PHP 5.2 and PHP 5.6. Committed to 7.x-1.x-dev.

Thanks, Liam!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.