If you try to edit subject or body of the system email "Admin (user awaiting approval)" (register_pending_approval_admin) on /admin/config/people/accounts, any changes are getting ignored by the UI.

I was able to edit all the other email string fields, but not this one. There is no error message shown or logged, but the changes won't get saved.

CommentFileSizeAuthor
#8 2656260-8.patch2.07 KBswentel
#8 2656260-8-fail.patch895 bytesswentel
#6 2656260-6-fail.patch895 bytesswentel
#2 2656260-2.patch1.2 KBswentel
#3 2656260-3.patch2.07 KBswentel
#3 2656260-3-fail.patch895 bytesswentel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

majusz created an issue. See original summary.

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Version: 8.0.2 » 8.0.x-dev
FileSize
2656260-2.patch1.2 KB

Confirmed - attached patch fixes it (going to look in the queue, it's kind of weird no-one else has reported this)

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Status: Active » Needs review
FileSize
2656260-3-fail.patch895 bytes
2656260-3.patch2.07 KB

Here's a test only and fix test patch at the same time.

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Status: Needs review » Needs work

Hmm, weird, fail patch should have failed ..

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Status: Needs work » Needs review

Ok, this is weird, this fails nicely on my local machine ...

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
FileSize
2656260-6-fail.patch895 bytes

re-uploading the fail patch, it's getting weird now as it fails on my local ci test bot too.

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented 
12:05:33 Drupal\user\Tests\UserAdminSettingsFormTest                    4 passes

It's as if the bot hasn't applied the patch at all, I don't get it. There should be at least 6 asserts (4 pass and 2 fail)

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented
Issue tags: +Configuration system
FileSize
2656260-8-fail.patch895 bytes
2656260-8.patch2.07 KB

The last submitted patch, 8: 2656260-8-fail.patch, failed testing.

swentel’s picture

swentel CreditAttribution: swentel as a volunteer commented

Ok, all is fine again after #2657482: Test bot doesn't apply the patch - RTBC anyone ? :)

amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

The last submitted patch, 3: 2656260-3-fail.patch, failed testing.

The last submitted patch, 6: 2656260-6-fail.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 93bdf96 and pushed to 8.0.x. Thanks!

  • alexpott committed aab13ba on 8.1.x 
    Issue #2656260 by swentel: Cannot edit system mail "Admin (user awaiting...

  • alexpott committed 93bdf96 on 
    Issue #2656260 by swentel: Cannot edit system mail "Admin (user awaiting...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.