Problem/Motivation

There are two button in the Selection step (Next button form EED and Select from EB). This is very confusing for the user, because a click on the Next button continues with an empty selection.

Proposed resolution

Hide the button von EED because EB controls the selection and propagates the selection to EE.

Before

After

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 hide_next_button_during-2656062-11.patch607 bytesthenchev
#8 2656062-8.patch636 byteswebflo
#2 2656062-1.patch561 byteswebflo
#2 after.jpg60.82 KBwebflo
#2 before.jpg62.23 KBwebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Issue summary: View changes
FileSize
before.jpg62.23 KB
after.jpg60.82 KB
2656062-1.patch561 bytes
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Issue summary: View changes
slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Category: Bug report » Task
Status: Active » Reviewed & tested by the community
Issue tags: +ux, +Media Initiative, +D8Media

Looks good to me.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Committed.

  • slashrsm committed c64f9dc on 8.x-1.x authored by webflo 
    Issue #2656062 by webflo: Hide Next button during Selection if Entity...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Closed (fixed) » Needs work
FileSize
2656062-8.patch636 bytes

I discovered that the form class changes sometimes, haven't figured out way. I follow-up on it soon. Here is an intermediate patch.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented

Its a race condition between the dialog api and the event we rely on. The dialog has not entity-select-dialog class at this point. It works fine if a add a timeout or use the other class which is generated via Drupal

JamesK’s picture

JamesK CreditAttribution: JamesK at Advisor Websites commented

Why not just use $('#drupal-modal').parent().find('.js-button-next')?
There can only be one modal open at a time, so the #drupal-modal selector is unique.

thenchev’s picture

thenchev CreditAttribution: thenchev at MD Systems GmbH for Acquia commented
Status: Needs work » Needs review
FileSize
hide_next_button_during-2656062-11.patch607 bytes

@JamesK thanks, this works for me.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano as a volunteer commented

Patch in #11 works for me as expected.

+1 for RTBC

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks good

slashrsm’s picture

slashrsm CreditAttribution: slashrsm at MD Systems GmbH for Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

  • slashrsm committed 657e32e on 8.x-1.x authored by Denchev 
    Issue #2656062 by webflo, Denchev, JamesK, marcoscano: Make hiding of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.