Problem/Motivation

In #2654944: Provide test credentials button and callbacks in base UI class we introduced "Test credentials" button to check private/public keys and update remote languages mappings. It will be replaced to "Connect" button in #2658072: Replace "Test credentials" with "Connect" button

Proposed resolution

Support it in Gengo module.

CommentFileSizeAuthor
#14 add_connect_button-2655948-12-interdiff.txt8 KBBerdir
#14 add_connect_button-2655948-12.patch7.81 KBBerdir
#12 tmgmt-twig-2695153-5-interdiff.txt3.04 KBBerdir
#12 tmgmt-twig-2695153-5.patch29.06 KBBerdir
#10 add_connect_button-2655948-10-interdiff.txt521 bytesmbovan
#10 add_connect_button-2655948-10.patch3.27 KBmbovan
#8 add_connect_button-2655948-8.patch2.92 KBmbovan
#8 add_connect_button-2655948-8-interdiff.txt2.29 KBmbovan
#3 gengo_checkout_form.png79.02 KBmbovan
#3 replace_test-2658072-3.patch650 bytesmbovan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Title: Add "Test credentials" button » Add "Connect" button
Issue summary: View changes
Related issues: +#2658072: Replace "Test credentials" with "Connect" button
mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Category: Task » Feature request
Issue summary: View changes
Status: Active » Needs review
FileSize
replace_test-2658072-3.patch650 bytes
gengo_checkout_form.png79.02 KB

Added "Connect" button after "private key" field.

Status: Needs review » Needs work

The last submitted patch, 3: replace_test-2658072-3.patch, failed testing.

The last submitted patch, 3: replace_test-2658072-3.patch, failed testing.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented

Tested locally, no fails, not sure why it's failing on test bot.
This #2658072: Replace "Test credentials" with "Connect" button has to be committed first. :P

The last submitted patch, 3: replace_test-2658072-3.patch, failed testing.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
add_connect_button-2655948-8-interdiff.txt2.29 KB
add_connect_button-2655948-8.patch2.92 KB

There is a new release of TMGMT, rerolling and adding tests for MyGengo.

Status: Needs review » Needs work

The last submitted patch, 8: add_connect_button-2655948-8.patch, failed testing.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
add_connect_button-2655948-10.patch3.27 KB
add_connect_button-2655948-10-interdiff.txt521 bytes

Debugged the test fail. The branch is failing since #2673172: Add a configuration option whether continuous job items should be submitted immediately or on cron where was added inactive state for job items.

Not related to this issue, it's an one-liner, but I think we can fix it here.

Edit: Updated the related issue.

edurenye’s picture

edurenye CreditAttribution: edurenye at MD Systems GmbH commented
Status: Needs review » Needs work

Are you sure this last change is correct?
When you submit a Job, all it's items should change to active, isn't it?
I think something it's really wrong there.

Also the first time you open the provider settings page, should not show an error with the connection.
Moreover I think that it should get the account status instead of the language mappings to check if the connection works, then you can check both private and public key as right now is just checking the public one.
http://developers.gengo.com/v2/api_methods/account/#stats-get

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
tmgmt-twig-2695153-5.patch29.06 KB
tmgmt-twig-2695153-5-interdiff.txt3.04 KB

I like that.

Added the statistics API and updated the tests for how it works with that.

The active thing is a bug, but it's a bug in TMGMT: #2695217: Job items are not set to active if the job has been rejected previously.

Status: Needs review » Needs work

The last submitted patch, 12: tmgmt-twig-2695153-5.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
add_connect_button-2655948-12.patch7.81 KB
add_connect_button-2655948-12-interdiff.txt8 KB

Wrong patch...

  • Berdir committed a0cc128 on 8.x-1.x 
    Issue #2655948 by mbovan, Berdir: Add "Connect" button
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Committed.

The last submitted patch, 10: add_connect_button-2655948-10.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.