Fix Order edit JS [#2655586]

The JavaScript on the order edit page has not yet been ported to D8 and doesn't work.

I have rolled a patch to fix this, but I am holding it back until #2573299: Convert order panes to plugins gets committed because I don't want to make changes that break the patch in that issue.

Comment	File	Size	Author
#18	pane-container-quote.patch	1023 bytes	TR
#18	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 202 pass
#17	pane-container-customer.patch	682 bytes	TR
#17	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 202 pass, 8 fail
#16	pane-container.patch	2.08 KB	TR
#16	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 202 pass
#15	payment-order-pane-container.patch	758 bytes	TR
#15	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 202 pass
#12	container.patch	5.5 KB	TR
#12	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 199 pass, 8 fail
#10	order-js-js-3.patch	14.36 KB	TR
#10	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 182 pass
#8	order-js-js-2.patch	18.91 KB	TR
#8	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 182 pass
#7	order-js-js.patch	14.31 KB	TR
#7	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 182 pass
#5	order-js-2.patch	33.06 KB	TR
#5	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 182 pass
#2	order-js-1.patch	28.83 KB	TR
#2	8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 182 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

23 January 2016 at 22:52

TR created an issue. See original summary.

Comment #2

TR CreditAttribution: TR commented 25 January 2016 at 06:03

Status:

Active

» Needs review

File	Size
order-js-1.patch	28.83 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 182 pass, 1 fail

This involves a lot more code than I thought, so I'm going to do it incrementally. First step is to take the JavaScript callback functions, which are all in uc_order.admin.inc, and move them into their own controllers/forms and add routes for the callbacks. uc_order.admin.inc and hook_menu() can now be removed.

Comment #3

25 January 2016 at 06:41

Status:

Needs review

» Needs work

The last submitted patch, 2: order-js-1.patch, failed testing.

Comment #4

TR CreditAttribution: TR commented 25 January 2016 at 07:08

That's a branch fail from commit 2919ba1c8d7

Comment #5

TR CreditAttribution: TR commented 25 January 2016 at 21:59

Status:

Needs work

» Needs review

File	Size
order-js-2.patch	33.06 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 182 pass

Tests are running again, and this patch does more than the previous. Let's try it ...

Comment #6

25 January 2016 at 22:54

TR committed c322d24 on 8.x-4.x

Issue #2655586 by TR: Fix Order edit JS, part 1

Comment #7

TR CreditAttribution: TR commented 26 January 2016 at 01:01

File	Size
order-js-js.patch	14.31 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 182 pass

And here's the first pass at the JavaScript. This fixes the actions on the copy billing to shipping, copy shipping to billing, search for a customer, and create a new customer icons. This is still a work in progress. The address book icons and the customer search/create subform buttons are still broken.

Comment #8

TR CreditAttribution: TR commented 26 January 2016 at 05:36

File	Size
order-js-js-2.patch	18.91 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 182 pass

A couple of more changes, so one more test before I commit this ...

Comment #9

26 January 2016 at 05:59

TR committed a88031c on 8.x-4.x

Issue #2655586 by TR: Fix Order edit JS, part 2

Comment #10

TR CreditAttribution: TR commented 27 January 2016 at 07:34

File	Size
order-js-js-3.patch	14.36 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 182 pass

More work. The only thing that doesn't work now is the submit/close buttons on the JS-loaded form elements - I know the reason for this, that will be the next fix.

Comment #11

27 January 2016 at 07:57

TR committed 6677bd5 on 8.x-4.x

Issue #2655586 by TR: Fix Order edit JS, part 3

Comment #12

TR CreditAttribution: TR commented 19 February 2016 at 05:52

File	Size
container.patch	5.5 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 199 pass, 8 fail

Replace <div> with #type 'container'.

Comment #13

19 February 2016 at 06:01

Status:

Needs review

» Needs work

The last submitted patch, 12: container.patch, failed testing.

Comment #14

19 February 2016 at 06:17

The last submitted patch, 12: container.patch, failed testing.

Comment #15

TR CreditAttribution: TR commented 24 February 2016 at 08:57

Status:

Needs work

» Needs review

File	Size
payment-order-pane-container.patch	758 bytes
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 202 pass

Comment #16

TR CreditAttribution: TR commented 24 February 2016 at 09:12

File	Size
pane-container.patch	2.08 KB
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 202 pass

Comment #17

TR CreditAttribution: TR commented 24 February 2016 at 09:25

File	Size
pane-container-customer.patch	682 bytes
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 202 pass, 8 fail

Comment #18

TR CreditAttribution: TR commented 24 February 2016 at 09:30

File	Size
pane-container-quote.patch	1023 bytes
8.x-4.x: PHP 5.5 & MySQL 5.5, D8.1 202 pass

Comment #19

24 February 2016 at 09:34

The last submitted patch, 17: pane-container-customer.patch, failed testing.

Comment #20

kiwad CreditAttribution: kiwad commented 29 June 2017 at 15:56

Status:

Needs review

» Needs work

Few failed tests... what needs to be reviewed ? Is this task still relevant ? I've look for instance at uc_quote.module and what's in the patch #18 already seems to be applied

Comment #21

TR CreditAttribution: TR commented 30 June 2017 at 03:52

Assigned:

» Unassigned

This is just a patch testing issue. Everything above has been committed in some form, but the task of rewriting the order edit JS is not complete. It's a 'task' not a bug or a feature request because this is part of the porting of the order admin from D7 to D8 - there's lots of known issues because it's an incomplete task.

I haven't worked on it in a while, so feel free to jump in and finish it off if you want.