Problem/Motivation

The main drawback of this module is that you end up with lots of modules installed that aren't doing anything.

Proposed resolution

Add a post-post update that:
- finds installed update modules
- uninstalls them
- adds them to a variable (using variable_get()/set() for now) so that they don't get re-installed.

Also ensure the before/after installs check that variable before they install anything.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 dum-rum-2655340-6.patch5.97 KBplach
#6 dum-rum-2655340-6.interdiff.txt2 KBplach
#4 dum-rum-2655340-4.patch6.29 KBplach
#4 dum-rum-2655340-4.interdiff.txt612 bytesplach
#3 dum-rum-2655340-3.interdiff.txt4.46 KBplach
#3 dum-rum-2655340-3.patch6.22 KBplach
#2 dum-rum-2655340-2.patch5.47 KBplach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch created an issue. See original summary.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach at Tag1 Consulting commented
Status: Active » Needs review
FileSize
dum-rum-2655340-2.patch5.47 KB

Here's a patch implementing the proposed solution and an additional drush rum command that will remove uninstalled DUMs. Actually it will move them to a removed subdirectory and rename .info files to .info.removed so they will no longer be detected as modules.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach at Tag1 Consulting commented
FileSize
dum-rum-2655340-3.patch6.22 KB
dum-rum-2655340-3.interdiff.txt4.46 KB

Actually, I didn't realize DUM is already keeping track of seen modules. Refactored the previous patch to use that instead.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach at Tag1 Consulting commented
FileSize
dum-rum-2655340-4.interdiff.txt612 bytes
dum-rum-2655340-4.patch6.29 KB

One more little fix, we should be good now

marco’s picture

marco CreditAttribution: marco at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested, this works well.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach at Tag1 Consulting commented
Status: Reviewed & tested by the community » Needs review
FileSize
dum-rum-2655340-6.interdiff.txt2 KB
dum-rum-2655340-6.patch5.97 KB

Actually it seems drush can pick up the .drush.inc code even before the module is enabled, which makes the update fail because the .module is not enabled yet. This updated patch takes case of that.

marco’s picture

marco CreditAttribution: marco at Tag1 Consulting commented
Status: Needs review » Reviewed & tested by the community

I've verified the issue mentioned above can happen, and that the change prevents it.

  • plach committed 80ccc82 on 7.x-1.x 
    Issue #2655340 by plach, catch, marco: Track update modules,...
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach at Tag1 Consulting commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.