Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When using an existing config directory the check for it to be writeable should be omitted.
Comment | File | Size | Author |
---|---|---|---|
#5 | 2655130-5.patch | 1.42 KB | alexpott |
#2 | 2655130-2.patch | 1.08 KB | bircher |
Comments
Comment #2
bircherComment #3
alexpottI wonder if this is testable? The profile has tests for both an existing directory and a tarball.. perhaps the test could make the folder not writeable after putting the config in it. We also still need to check it exists even if we're not doing an upload.
Comment #4
alexpottThis condition does not look quite right.
I think we should create if it is not there. If this fails we should error because this is a mistake.
Then if we have an upload we need to ensure it is writable.
Comment #5
alexpottTried to write a test. But we can't just do it because chmodding to 0444 always results in 0644. Manually tested this and it is all good.
Comment #6
alexpottComment #7
alexpottNo test fails.
Comment #8
alexpott