Problem/Motivation

Since this issue was commited #1494670: References to CSS, JS, and similar files should be root-relative URLs: avoids mixed content warnings & fewer bytes to send.
Running core/scripts/run-tests.sh tests with --browser doesn't add the CSS nither the images.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 run_test_browser-2655102-3.patch1.5 KBedurenye
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

edurenye created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#1494670: References to CSS, JS, and similar files should be root-relative URLs: avoids mixed content warnings & fewer bytes to send

Loading HTML that is intended for consumption via http://domain.com/subdir and expecting it to load just as fine in file:// … that doesn't really make sense

I'm happy to look at ways to improve that, but it makes no sense to prioritize --browser over real-world site usage considerations

Why not load it via http://?

edurenye’s picture

edurenye CreditAttribution: edurenye at MD Systems GmbH commented
Status: Active » Needs review
FileSize
run_test_browser-2655102-3.patch1.5 KB

Here is a quick fix.

Status: Needs review » Needs work

The last submitted patch, 3: run_test_browser-2655102-3.patch, failed testing.

The last submitted patch, 3: run_test_browser-2655102-3.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs review » Reviewed & tested by the community

lgtm

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Manually tested - works great. Committed e6eacaf and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed dd13af2 on 8.1.x 
    Issue #2655102 by edurenye: Run test --browser missing CSS and images

  • alexpott committed e6eacaf on 
    Issue #2655102 by edurenye: Run test --browser missing CSS and images

(...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.