Closed (fixed)
Project:
Link
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Jan 2016 at 14:06 UTC
Updated:
21 Feb 2019 at 06:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
recrit commentedThe patch attached adds 2 new types - LINK_FRAGMENT and LINK_QUERY.
Comment #3
acPatch doesn't fully work
1) # is encoded to %2523
2) you still can't input a path like 'foo#bar'
The module claims to be able to handle anchor links but currently that seems broken.
Comment #4
acScratch that, the encoding issue was elsewhere and you can already input foo#bar by using node/x#bar
Comment #5
recrit commented@ac, this patch is to add only an anchor link or query link that uses the base as the current page.
Comment #6
dgtlmoon commented#1914072: Link Module displays malformed external URL
Comment #7
moleCuleFFF commentedThis patch does not work in the situation where a node is being used as the homepage as the URL is rewritten with the alias of node in full.
e.g.:
homepage#panels-ipe-regionid-centerI will provide a new patch. Also the suggested duplicate issue is in regards to rewriting of URL's, not the issue here. Reopening
Comment #8
moleCuleFFF commentedComment #9
moleCuleFFF commentedAdded check for homepage to logic
Comment #10
moleCuleFFF commentedNew patch includes patch from issue #1914072: Link Module displays malformed URL
Comment #11
moleCuleFFF commentedComment #12
sdstyles commentedPatch reroll.
Comment #13
apugacescu commentedbreaks internal urls when they are displayed on homepage, not sure why @moleCuleFFF added 'Added check for homepage to logic' could you please share some context?
Checked
<front>url is handled correctly by 'url' function without this logic, attaching patch.Comment #15
apugacescu commentedFixed file paths in previous patch.
Comment #16
apugacescu commentedComment #18
apugacescu commentedRerolled patch.
Comment #19
ok4p1 commentedHere there is a patch for the version 1.4 in case anyone needs it.
Comment #20
apugacescu commentedComment #21
pifagorHello @okapi1987@gmail.com
Create the patch correctly
git diff > [description]-[issue-number]-[comment-number].patchfor the version 7.x-1.x-devComment #22
apugacescu commentedCreated on top of latest dev.
Comment #23
apugacescu commentedComment #24
rajiv.singh commentedRerolled patch
Comment #26
whthat commentedUpdated Patch by removing the including of patch from issue #1914072: Link Module displays malformed URL. #1914072 is not complete and UTF8 detection does not appear to be even working, best to leave that patch seperate for now. The inclusion only complicates this Anchor and Query String patch by duplicating its fragments, this could work if moved just before the $item array build.
Comment #27
chris matthews commentedThe patch in #26 applied cleanly to the latest link 7.x-1.x-dev, but still need to be reviewed.
Comment #28
nishruu commentedI use it with success on a website.
Comment #29
pifagorComment #31
pifagor