When creating a Content Revisions view there are relationships for historical data of a field that can be added. For Atom Reference fields this relationship is unavailable. This happens because the hook atom_reference_field_views_data() doesn't account for a relationship on the field's revision table.

CommentFileSizeAuthor
#4 scald-atom-reference-field-views-relationship-2653908-4.patch1.22 KBgclicon
#2 scald-atom-reference-field-views-relationship-2653908-1.patch1.22 KBgclicon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gclicon created an issue. See original summary.

gclicon’s picture

gclicon CreditAttribution: gclicon at Achieve Internet commented
FileSize
scald-atom-reference-field-views-relationship-2653908-1.patch1.22 KB

Attached is a patch to resolve this issue.

Thanks!

nagy.balint’s picture

nagy.balint CreditAttribution: nagy.balint commented

Hi!

Thanks for the patch.

There is a typo in this line
'label' => t('attom reference item revision from !field_name', array('!field_name' => $field['field_name'])),

Also maybe it should be started with a capital letter.

gclicon’s picture

gclicon CreditAttribution: gclicon at Achieve Internet commented
Status: Active » Needs review
FileSize
scald-atom-reference-field-views-relationship-2653908-4.patch1.22 KB

Good catch. I updated label text as suggested.

nagy.balint’s picture

nagy.balint CreditAttribution: nagy.balint commented

@jcisio : Can you double check that this can go into Scald core?

  • DeFr committed 1d25465 on 7.x-1.x authored by gclicon 
    Issue #2653908 by gclicon: Atom Reference Field lacks revision...
DeFr’s picture

DeFr CreditAttribution: DeFr at Axess Open Web Services commented
Status: Needs review » Fixed

Looks fine, did various test that behaved as expected, patch pushed.

Sorry for the delay for the review :-(

Welcome in the Scald contributors family @gclicon :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.