Is useful also pass the element in popupClickHandler.

Tks,

CommentFileSizeAuthor
#11 2653828-11-D8.patch300 bytesrodrigoeg
#7 pass_element_popup_click_handler-2653828-7.patch342 bytesrodrigoeg
#2 PassElementPopupClickHandler-2653828-1.patch342 bytesljcarnieri
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ljcarnieri created an issue. See original summary.

ljcarnieri’s picture

ljcarnieri CreditAttribution: ljcarnieri at CI&T for CI&T commented
FileSize
PassElementPopupClickHandler-2653828-1.patch342 bytes
ljcarnieri’s picture

ljcarnieri CreditAttribution: ljcarnieri at CI&T for CI&T commented
Status: Active » Needs review
rodrigoeg’s picture

rodrigoeg CreditAttribution: rodrigoeg at CI&T commented
Assigned: Unassigned » rodrigoeg
rodrigoeg’s picture

rodrigoeg CreditAttribution: rodrigoeg at CI&T commented
Assigned: rodrigoeg » Unassigned
Status: Needs review » Reviewed & tested by the community

Patch reviewed and tested.

rodrigoeg’s picture

rodrigoeg CreditAttribution: rodrigoeg at CI&T commented
Status: Reviewed & tested by the community » Needs work

@ljcarnieri, the comment id on the file name is incorrect (it was 2 instead of 1).
Could you please change the name?
Other than that, the patch is ok.

rodrigoeg’s picture

rodrigoeg CreditAttribution: rodrigoeg at CI&T commented
Status: Needs work » Needs review
FileSize
pass_element_popup_click_handler-2653828-7.patch342 bytes

Submitting the patch again with the same content, but only correcting the file name.

atoledo@ciandt.com’s picture

atoledo@ciandt.com CreditAttribution: atoledo@ciandt.com at CI&T commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested. The element is passed and is accessible for a custom popupClickHandler.

elachlan’s picture

elachlan CreditAttribution: elachlan commented

Does the same apply to drupal 8?

Could you please provide a patch for it as well?

  • elachlan committed 13ef0ee on 7.x-1.x authored by rodrigoeg 
    Issue #2653828 by ljcarnieri, rodrigoeg: Also pass the element in...
rodrigoeg’s picture

rodrigoeg CreditAttribution: rodrigoeg at CI&T commented
FileSize
2653828-11-D8.patch300 bytes

I created one patch for Drupal 8. I noticed there is the extlink.min.js too, but I am not sure how your are generating this file, so I didn't include in the patch.

rodrigoeg’s picture

rodrigoeg CreditAttribution: rodrigoeg at CI&T commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Reviewed & tested by the community » Needs review

  • elachlan committed 1eb9da7 on 8.x-1.x authored by rodrigoeg 
    Issue #2653828 by rodrigoeg, ljcarnieri: Also pass the element in...
elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.