I only just noticed this, but we renamed facet-api to facets for drupal 8, this means that the current FacetApiQueryTypeMappingInterface should be renamed to FacetsQueryTypeMappingInterface. Any documentation should also be updated to reflect that name.

CommentFileSizeAuthor
#2 search_api-rename_facetapiquerytypemappinginterface-2653632-2.patch1.93 KBalan-ps
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

alan-ps’s picture

alan-ps CreditAttribution: alan-ps commented
Status: Active » Needs review
FileSize
search_api-rename_facetapiquerytypemappinginterface-2653632-2.patch1.93 KB

This is a patch.

1. src/FacetApiQueryTypeMappingInterface.php renamed to src/FacetsQueryTypeMappingInterface.php
2. all mentions of Facet Api replaced to Facets.

I guess I missed nothing:)

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ for Acquia commented
Status: Needs review » Reviewed & tested by the community

Awesome, thanks

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey for Acquia commented
Status: Reviewed & tested by the community » Fixed

The comment was now wrapped at the wrong point (Joris must be getting old … ;P), but other than that this looks great, of course.
Committed.
Thanks!

  • drunken monkey committed 0cce022 on 8.x-1.x authored by alan-ps 
    Issue #2653632 by alan-ps: Renamed FacetApiQueryTypeMappingInterface to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.