Hi there,

I'm usually good at attributing commits, but I made a terrible mistake this morning! I committed an entire Drupal 8 port without properly attributing the author - Erik here should have all of the credit: https://www.drupal.org/u/erikwegner

Since attribution is now *really* important, I've been trying to fix this. I tried the steps outlined here:

http://stackoverflow.com/a/28845565

And that worked locally, here's a snip from my git log:

commit 03e6a515411792bebcec28fb4037acde9310428c
Author: Greg Harvey <greg.harvey@gmail.com>
Date:   Wed Jan 20 15:21:54 2016 +0100

    Merge branch '8.x-1.x' of git.drupal.org:project/nagios into 8.x-1.x

commit 8607fe3e834b5bbe815fbeef4d1c15985fe518cf
Author: ErikWegner <ErikWegner@734338.no-reply.drupal.org>
Date:   Wed Jan 20 11:25:46 2016 +0100

    Issue #2598364 by ErikWegner: Initial Drupal 8 of Nagios module.

commit 02aadb4303f28acdbf6b139605d8d76cf88839e6
Author: ErikWegner <ErikWegner@734338.no-reply.drupal.org>
Date:   Wed Jan 20 11:25:46 2016 +0100

    Issue #2598364 by ErikWegner: Initial Drupal 8 of Nagios module.

commit f0afe75c87c9dd80f8784c930ebf216c9c7d5414
Author: greg.harvey <greg.harvey@130383.no-reply.drupal.org>
Date:   Thu Oct 8 18:52:21 2015 +0200

    Issue #2583751 by greg.harvey: Drush updates checker only announces critical for 'security' check, not 'all'

But on the Drupal.org repo browser it still shows me as the author of commit 8607fe3e834b5bbe815fbeef4d1c15985fe518cf:
http://cgit.drupalcode.org/nagios/commit/?id=8607fe3

Ditto on the project commits page:
https://www.drupal.org/node/368588/commits

I'm anxious that A) I don't get credit I don't deserve and B) Erik gets the credit he very much deserves! Maybe it's OK now? But I'd be hugely grateful if someone who knows Git better than I could have a look and see if this is now fairly attributed to Erik.

Sorry about this! :(

Comments

greg.harvey created an issue. See original summary.

naveenvalecha’s picture

Project: Drupal.org site moderators » Drupal.org infrastructure
Component: Project/Git problem » Git

Commits are immuttable, AFAIK, there is no option with that other than reverting the commit and then do the correct commit.

May be drumm can propose a better option

drumm’s picture

Status: Active » Closed (works as designed)

Yes, commits are immutable.

However, the newer things like “Credited on … issues fixed in the past 3 months” on user and organization pages get data from the “Credit & committing” fieldset at the bottom of issues. Project maintainers can update that at any time.