When changing to a new shortcut set from the default shortcut set, the display breaks due to markup changing:

A default shortcut list item looks like this:

<li class="first leaf navbar-menu-item-processed navbar-level-1">
  <div class="navbar-box">
    <a href="/express2/node/add" class="navbar-menu-item">Add content</a>
  </div>
</li>

After changing the shortcut set, a shortcut list item looks like this:

<li class="first leaf">
  <a href="/express2/node/add">Add content</a>
</li>

Clearing the cache seems to fix the problem, but that should be added to the submit function rather than requiring the user to do it manually, especially if you have users that do not have that access.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kevincrafts created an issue. See original summary.

kevincrafts’s picture

This patch should be more targeted in the cache clearing, but it was the only way I was able to get the menu to display properly. Perhaps someone more familiar with this project could make this more targeted.

B-Prod’s picture

Status: Active » Needs review
FileSize
752 bytes

Almost same approach than #2, but:

  • only clear the theme registry, not all cache
  • the rebuild is only performed when creating a new set or deleting one, but not each time a set is switched (performances killer)

Status: Needs review » Needs work

The last submitted patch, 3: navbar-shortcut-rebuild-theme--2653122-3.patch, failed testing.

B-Prod’s picture

Status: Needs work » Needs review

I clearly not understand the new testing system :-(
The tests result is 10:26:37 ERROR: No valid tests were specified.

I don't know what it means, but the patch clearly does not break other features...

The last submitted patch, 2: navbar-shortcut_switch_menu_display-2653122-2-7.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: navbar-shortcut-rebuild-theme--2653122-3.patch, failed testing.

B-Prod’s picture

Status: Needs work » Needs review
FileSize
752 bytes

Same patch as #3, without testing.