Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
This should be more or less straight port of the 'Define canvas' effect from D7 version of ImageCache actions module.
Proposed resolution
Provide patch and test coverage.
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff_5-7.txt | 6 KB | mondrake |
#7 | 2652898-7.patch | 46.17 KB | mondrake |
#5 | 2652898-5.patch | 46.17 KB | mondrake |
Comments
Comment #2
mondrakeFirst patch, tests are missing. Takes loads of helpers from Textimage.
Comment #3
mondrakeComment #4
mondrakeAdding tests, ready for review.
Comment #5
mondrakeAdding the effect to the table in README.md
Comment #6
mondrakeComment #7
mondrakeRenamed the configuration key 'canvas_mode' to 'canvas_size', to make it more clear what it is about. Possibly in the future this effect may also include a background image to be set as canvas, rather than just the current color/transparency. But I'd leave that to a follow up as this patch is just porting the equivalent effect from ImageCache Actions, and is already big enough.
Comment #9
slashrsm CreditAttribution: slashrsm at Examiner.com commentedPatch needed reroll, but it wasn't to bad. Committed. Thanks!