In http://cgit.drupalcode.org/link/commit/?id=2e82084e104ed8696c1fda15f001b... , the array is not formatted according to Drupal coding standards, https://www.drupal.org/coding-standards#array , "each element should be broken into its own line"

Patch to follow.

CommentFileSizeAuthor
#2 link-code-standards-array-2650956-2.patch830 bytesloopduplicate
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

loopduplicate created an issue. See original summary.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
Assigned: loopduplicate » Unassigned
Status: Active » Needs review
FileSize
link-code-standards-array-2650956-2.patch830 bytes
amitmaity’s picture

amitmaity CreditAttribution: amitmaity commented

The patch fixes the drupal coding standard.

karsumit94’s picture

karsumit94 CreditAttribution: karsumit94 commented

The coding standard has been followed in the patch by @loopduplicate

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
Status: Needs review » Reviewed & tested by the community
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Assigned: Unassigned » renatog
Issue tags: +ciandt-contrib

Make sense.

Works good for me too.

  • RenatoG committed f51b531 on 7.x-1.x authored by loopduplicate 
    Issue #2650956 by loopduplicate, amitmaity, karsumit94, RenatoG: Code...
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented

Thank you very much for contributions guys.

Fixed.

Commited in dev branch.

Good Work and Good Weekend.

Regards.

renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Status: Reviewed & tested by the community » Fixed
renatog’s picture

renatog
Location Campinas
CreditAttribution: renatog at CI&T commented
Issue tags: +code-review

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.